From a056a7b3716bd4cc78e47e64f7d735c5bd5b82e6 Mon Sep 17 00:00:00 2001 From: Titus Wormer Date: Wed, 29 Jun 2022 17:15:17 +0200 Subject: Fix a bunch of bugs with definitions, references * Fix bug where whitespace after `:` was not allowed, it is * Fix bug where escapes in labels did not work due to typo * Fix to prefer first definition * Fix whitespace after definitions * Fix matching by adding normalizing * Fix reference from being output as data --- tests/definition.rs | 148 +++++++++++++++++++++++++--------------------------- 1 file changed, 71 insertions(+), 77 deletions(-) (limited to 'tests') diff --git a/tests/definition.rs b/tests/definition.rs index c112a96..3edf687 100644 --- a/tests/definition.rs +++ b/tests/definition.rs @@ -27,12 +27,17 @@ fn definition() { "should support whitespace and line endings in definitions" ); - // To do: some bug. - // assert_eq!( - // micromark("[Foo*bar\\]]:my_(url) 'title (with parens)'\n\n[Foo*bar\\]]"), - // "

Foo*bar]

", - // "should support complex definitions (1)" - // ); + assert_eq!( + micromark("[a]:b 'c'\n\n[a]"), + "

a

", + "should support no whitespace after `:` in definitions" + ); + + assert_eq!( + micromark("[Foo*bar\\]]:my_(url) 'title (with parens)'\n\n[Foo*bar\\]]"), + "

Foo*bar]

", + "should support complex definitions (1)" + ); assert_eq!( micromark("[Foo bar]:\n\n'title'\n\n[Foo bar]"), @@ -82,33 +87,29 @@ fn definition() { "should support character escapes in destinations and titles" ); - // Some bug. - // assert_eq!( - // micromark("[foo]\n\n[foo]: url"), - // "

foo

\n", - // "should support a link before a definition" - // ); + assert_eq!( + micromark("[foo]\n\n[foo]: url"), + "

foo

\n", + "should support a link before a definition" + ); - // Some bug. - // assert_eq!( - // micromark("[foo]: first\n[foo]: second\n\n[foo]"), - // "

foo

", - // "should match w/ the first definition" - // ); + assert_eq!( + micromark("[foo]: first\n[foo]: second\n\n[foo]"), + "

foo

", + "should match w/ the first definition" + ); - // Some bug. - // assert_eq!( - // micromark("[FOO]: /url\n\n[Foo]"), - // "

Foo

", - // "should match w/ case-insensitive (1)" - // ); + assert_eq!( + micromark("[FOO]: /url\n\n[Foo]"), + "

Foo

", + "should match w/ case-insensitive (1)" + ); - // Some bug. - // assert_eq!( - // micromark("[ΑΓΩ]: /φου\n\n[αγω]"), - // "

αγω

", - // "should match w/ case-insensitive (2)" - // ); + assert_eq!( + micromark("[ΑΓΩ]: /φου\n\n[αγω]"), + "

αγω

", + "should match w/ case-insensitive (2)" + ); assert_eq!( micromark("[foo]: /url"), @@ -183,14 +184,13 @@ fn definition() { "should not support setext heading underlines after definitions" ); - // To do: some bug. - // assert_eq!( - // micromark( - // "[foo]: /foo-url \"foo\"\n[bar]: /bar-url\n \"bar\"\n[baz]: /baz-url\n\n[foo],\n[bar],\n[baz]" - // ), - // "

foo,\nbar,\nbaz

", - // "should support definitions after definitions" - // ); + assert_eq!( + micromark( + "[foo]: /foo-url \"foo\"\n[bar]: /bar-url\n \"bar\"\n[baz]: /baz-url\n\n[foo],\n[bar],\n[baz]" + ), + "

foo,\nbar,\nbaz

", + "should support definitions after definitions" + ); // To do: block quote. // assert_eq!( @@ -200,12 +200,11 @@ fn definition() { // ); // Extra - // To do: some bug. - // assert_eq!( - // micromark("[\\[\\+\\]]: example.com\n\nLink: [\\[\\+\\]]."), - // "

Link: [+].

", - // "should match w/ character escapes" - // ); + assert_eq!( + micromark("[\\[\\+\\]]: example.com\n\nLink: [\\[\\+\\]]."), + "

Link: [+].

", + "should match w/ character escapes" + ); assert_eq!( micromark("[x]: \\\" \\(\\)\\\"\n\n[x]"), @@ -261,25 +260,23 @@ fn definition() { "should support character escapes at the start of a title" ); - // To do: some bug. - // assert_eq!( - // micromark("[x]: a \"\\\"\"\n\n[x]"), - // "

x

", - // "should support double quoted titles" - // ); + assert_eq!( + micromark("[x]: a \"'\"\n\n[x]"), + "

x

", + "should support double quoted titles" + ); assert_eq!( micromark("[x]: a '\"'\n\n[x]"), "

x

", - "should support double quoted titles" + "should support single quoted titles" ); - // To do: some bug. - // assert_eq!( - // micromark("[x]: a (\"\")\n\n[x]"), - // "

x

", - // "should support paren enclosed titles" - // ); + assert_eq!( + micromark("[x]: a (\"')\n\n[x]"), + "

x

", + "should support paren enclosed titles" + ); assert_eq!( micromark("[x]: a(()\n\n[x]"), @@ -305,12 +302,11 @@ fn definition() { "should support trailing whitespace after a destination" ); - // To do: some bug. - // assert_eq!( - // micromark("[x]: a \"\"X \t\n\n[x]"), - // "

x

", - // "should support trailing whitespace after a destination" - // ); + assert_eq!( + micromark("[x]: a \"X\" \t\n\n[x]"), + "

x

", + "should support trailing whitespace after a title" + ); assert_eq!( micromark("[&©&]: example.com/&©& \"&©&\"\n\n[&©&]"), @@ -331,12 +327,11 @@ fn definition() { ); // See: - // To do: some bug. - // assert_eq!( - // micromark("[x]: <> \"\"\n[][x]"), - // "

", - // "should ignore an empty title" - // ); + assert_eq!( + micromark("[x]: <> \"\"\n[][x]"), + "

", + "should ignore an empty title" + ); assert_eq!( micromark_with_options("[a]\n\n[a]: ", DANGER), @@ -362,12 +357,11 @@ fn definition() { "should not support an extra right paren (`)`) in a raw destination" ); - // To do: some bug. - // assert_eq!( - // micromark("[a]\n\n[a]: a(1(2(3(4()))))b"), - // "

a

\n", - // "should support 4 or more sets of parens in a raw destination (link resources don’t)" - // ); + assert_eq!( + micromark("[a]\n\n[a]: a(1(2(3(4()))))b"), + "

a

\n", + "should support 4 or more sets of parens in a raw destination (link resources don’t)" + ); assert_eq!( micromark("[a]\n\n[a]: aaa)"), @@ -381,14 +375,14 @@ fn definition() { "should not support a final (unbalanced) right paren in a raw destination “before” a title" ); - // To do: some bug. + // To do: do not let code (indented) interrupt definitions. // assert_eq!( // micromark(" [a]: b \"c\"\n [d]: e\n [f]: g \"h\"\n [i]: j\n\t[k]: l (m)\n\t n [k] o"), // "

n k o

", // "should support subsequent indented definitions" // ); - // To do: some bug. + // To do: trim whitespace in paragraphs. // assert_eq!( // micromark("[a\n b]: c\n\n[a\n b]"), // "

a\nb

", -- cgit