From 9ce55eb51113b79d57b981ccd971242528a36395 Mon Sep 17 00:00:00 2001
From: Héctor Ramón Jiménez <hector@hecrj.dev>
Date: Sun, 28 Jul 2024 15:40:22 +0200
Subject: Make `underline` positioning aware of `line_height`

---
 widget/src/text/rich.rs | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

(limited to 'widget/src/text/rich.rs')

diff --git a/widget/src/text/rich.rs b/widget/src/text/rich.rs
index d179c2d6..096056d4 100644
--- a/widget/src/text/rich.rs
+++ b/widget/src/text/rich.rs
@@ -285,14 +285,15 @@ where
                 }
 
                 if span.underline || is_hovered_link {
+                    let size = span
+                        .size
+                        .or(self.size)
+                        .unwrap_or(renderer.default_size());
+
                     let line_height = span
                         .line_height
                         .unwrap_or(self.line_height)
-                        .to_absolute(
-                            span.size
-                                .or(self.size)
-                                .unwrap_or(renderer.default_size()),
-                        );
+                        .to_absolute(size);
 
                     for bounds in regions {
                         renderer.fill_quad(
@@ -302,7 +303,10 @@ where
                                         + translation
                                         + Vector::new(
                                             0.0,
-                                            line_height.0 * 0.8 + 1.0,
+                                            size.0
+                                                + (line_height.0 - size.0)
+                                                    / 2.0
+                                                - size.0 * 0.08,
                                         ),
                                     Size::new(bounds.width, 1.0),
                                 ),
-- 
cgit