From c0996923c6aab39bb61ca6d3310149c66a73fac8 Mon Sep 17 00:00:00 2001
From: Malte Veerman <malte.veerman@gmail.com>
Date: Fri, 17 Jan 2020 20:15:20 +0100
Subject: Batch image draw calls into one with multiple instances

---
 wgpu/src/image/raster.rs | 12 ++----------
 wgpu/src/image/vector.rs | 15 ++++-----------
 2 files changed, 6 insertions(+), 21 deletions(-)

(limited to 'wgpu/src/image')

diff --git a/wgpu/src/image/raster.rs b/wgpu/src/image/raster.rs
index 387bd23a..bca2ebda 100644
--- a/wgpu/src/image/raster.rs
+++ b/wgpu/src/image/raster.rs
@@ -3,7 +3,6 @@ use iced_native::image;
 use std::{
     collections::{HashMap, HashSet},
 };
-use guillotiere::Size;
 use debug_stub_derive::*;
 
 #[derive(DebugStub)]
@@ -72,17 +71,10 @@ impl Cache {
         encoder: &mut wgpu::CommandEncoder,
         atlas_array: &mut TextureArray,
     ) -> &Memory {
-        let _ = self.load(handle);
-
-        let memory = self.map.get_mut(&handle.id()).unwrap();
+        let memory = self.load(handle);
 
         if let Memory::Host(image) = memory {
-            let (width, height) = image.dimensions();
-            let size = Size::new(width as i32, height as i32);
-
-            let allocation = atlas_array.allocate(size);
-
-            atlas_array.upload(image, &allocation, device, encoder);
+            let allocation = atlas_array.upload(image, device, encoder);
 
             *memory = Memory::Device(allocation);
         }
diff --git a/wgpu/src/image/vector.rs b/wgpu/src/image/vector.rs
index a83d1a0a..9bddcc2b 100644
--- a/wgpu/src/image/vector.rs
+++ b/wgpu/src/image/vector.rs
@@ -3,7 +3,6 @@ use iced_native::svg;
 use std::{
     collections::{HashMap, HashSet},
 };
-use guillotiere::Size;
 use debug_stub_derive::*;
 
 #[derive(DebugStub)]
@@ -83,25 +82,19 @@ impl Cache {
         // We currently rerasterize the SVG when its size changes. This is slow
         // as heck. A GPU rasterizer like `pathfinder` may perform better.
         // It would be cool to be able to smooth resize the `svg` example.
-        if self.rasterized.get(&(id, width, height)).is_some() {
+        if self.rasterized.contains_key(&(id, width, height)) {
             let _ = self.svg_hits.insert(id);
             let _ = self.rasterized_hits.insert((id, width, height));
 
             return self.rasterized.get(&(id, width, height));
         }
 
-        let _ = self.load(handle);
-
-        match self.svgs.get(&handle.id()).unwrap() {
+        match self.load(handle) {
             Svg::Loaded(tree) => {
                 if width == 0 || height == 0 {
                     return None;
                 }
 
-                let size = Size::new(width as i32, height as i32);
-
-                let array_allocation = texture_array.allocate(size);
-
                 // TODO: Optimize!
                 // We currently rerasterize the SVG when its size changes. This is slow
                 // as heck. A GPU rasterizer like `pathfinder` may perform better.
@@ -121,13 +114,13 @@ impl Cache {
                     &mut canvas,
                 );
 
-                texture_array.upload(&canvas, &array_allocation, device, encoder);
+                let allocation = texture_array.upload(&canvas, device, encoder);
 
                 let _ = self.svg_hits.insert(id);
                 let _ = self.rasterized_hits.insert((id, width, height));
                 let _ = self
                     .rasterized
-                    .insert((id, width, height), array_allocation);
+                    .insert((id, width, height), allocation);
 
                 self.rasterized.get(&(id, width, height))
             }
-- 
cgit