From 75ae0de9bdd3376b6e537bf59030059c926114ee Mon Sep 17 00:00:00 2001 From: Michael Aaron Murphy Date: Wed, 16 Nov 2022 17:42:41 +0100 Subject: feat: SVG styling with icon fill color --- native/src/svg.rs | 14 ++++++++++++ native/src/widget/helpers.rs | 8 ++++++- native/src/widget/svg.rs | 53 +++++++++++++++++++++++++++++++++++--------- 3 files changed, 63 insertions(+), 12 deletions(-) (limited to 'native/src') diff --git a/native/src/svg.rs b/native/src/svg.rs index a8e481d2..08b0984a 100644 --- a/native/src/svg.rs +++ b/native/src/svg.rs @@ -6,11 +6,14 @@ use std::hash::{Hash, Hasher as _}; use std::path::PathBuf; use std::sync::Arc; +pub use iced_style::svg::{Appearance, StyleSheet}; + /// A handle of Svg data. #[derive(Debug, Clone)] pub struct Handle { id: u64, data: Arc, + appearance: Appearance, } impl Handle { @@ -36,6 +39,7 @@ impl Handle { Handle { id: hasher.finish(), data: Arc::new(data), + appearance: Appearance::default(), } } @@ -48,6 +52,16 @@ impl Handle { pub fn data(&self) -> &Data { &self.data } + + /// Returns the styling [`Appearance`] for the SVG. + pub fn appearance(&self) -> Appearance { + self.appearance + } + + /// Set the [`Appearance`] for the SVG. + pub fn set_appearance(&mut self, appearance: Appearance) { + self.appearance = appearance; + } } impl Hash for Handle { diff --git a/native/src/widget/helpers.rs b/native/src/widget/helpers.rs index 3bce9e60..e802f629 100644 --- a/native/src/widget/helpers.rs +++ b/native/src/widget/helpers.rs @@ -285,6 +285,12 @@ where /// /// [`Svg`]: widget::Svg /// [`Handle`]: widget::svg::Handle -pub fn svg(handle: impl Into) -> widget::Svg { +pub fn svg( + handle: impl Into, +) -> widget::Svg +where + Renderer: crate::svg::Renderer, + Renderer::Theme: crate::svg::StyleSheet, +{ widget::Svg::new(handle) } diff --git a/native/src/widget/svg.rs b/native/src/widget/svg.rs index 1015ed0a..c7eb4f6d 100644 --- a/native/src/widget/svg.rs +++ b/native/src/widget/svg.rs @@ -9,7 +9,7 @@ use crate::{ use std::path::PathBuf; -pub use svg::Handle; +pub use svg::{Handle, StyleSheet}; /// A vector graphics image. /// @@ -17,15 +17,25 @@ pub use svg::Handle; /// /// [`Svg`] images can have a considerable rendering cost when resized, /// specially when they are complex. -#[derive(Debug, Clone)] -pub struct Svg { +#[derive(Clone)] +#[allow(missing_debug_implementations)] +pub struct Svg +where + Renderer: svg::Renderer, + Renderer::Theme: StyleSheet, +{ handle: Handle, width: Length, height: Length, content_fit: ContentFit, + style: ::Style, } -impl Svg { +impl Svg +where + Renderer: svg::Renderer, + Renderer::Theme: StyleSheet, +{ /// Creates a new [`Svg`] from the given [`Handle`]. pub fn new(handle: impl Into) -> Self { Svg { @@ -33,22 +43,26 @@ impl Svg { width: Length::Fill, height: Length::Shrink, content_fit: ContentFit::Contain, + style: Default::default(), } } /// Creates a new [`Svg`] that will display the contents of the file at the /// provided path. + #[must_use] pub fn from_path(path: impl Into) -> Self { Self::new(Handle::from_path(path)) } /// Sets the width of the [`Svg`]. + #[must_use] pub fn width(mut self, width: Length) -> Self { self.width = width; self } /// Sets the height of the [`Svg`]. + #[must_use] pub fn height(mut self, height: Length) -> Self { self.height = height; self @@ -57,17 +71,29 @@ impl Svg { /// Sets the [`ContentFit`] of the [`Svg`]. /// /// Defaults to [`ContentFit::Contain`] + #[must_use] pub fn content_fit(self, content_fit: ContentFit) -> Self { Self { content_fit, ..self } } + + /// Sets the style variant of this [`Svg`]. + #[must_use] + pub fn style( + mut self, + style: ::Style, + ) -> Self { + self.style = style; + self + } } -impl Widget for Svg +impl Widget for Svg where Renderer: svg::Renderer, + Renderer::Theme: iced_style::svg::StyleSheet, { fn width(&self) -> Length { self.width @@ -114,12 +140,15 @@ where &self, _state: &Tree, renderer: &mut Renderer, - _theme: &Renderer::Theme, + theme: &Renderer::Theme, _style: &renderer::Style, layout: Layout<'_>, _cursor_position: Point, _viewport: &Rectangle, ) { + let mut handle = self.handle.clone(); + handle.set_appearance(theme.appearance(self.style)); + let Size { width, height } = renderer.dimensions(&self.handle); let image_size = Size::new(width as f32, height as f32); @@ -138,7 +167,7 @@ where ..bounds }; - renderer.draw(self.handle.clone(), drawing_bounds + offset) + renderer.draw(handle, drawing_bounds + offset); }; if adjusted_fit.width > bounds.width @@ -146,16 +175,18 @@ where { renderer.with_layer(bounds, render); } else { - render(renderer) + render(renderer); } } } -impl<'a, Message, Renderer> From for Element<'a, Message, Renderer> +impl<'a, Message, Renderer> From> + for Element<'a, Message, Renderer> where - Renderer: svg::Renderer, + Renderer: svg::Renderer + 'a, + Renderer::Theme: iced_style::svg::StyleSheet, { - fn from(icon: Svg) -> Element<'a, Message, Renderer> { + fn from(icon: Svg) -> Element<'a, Message, Renderer> { Element::new(icon) } } -- cgit