From 42b1bfe66d2407901c1ae640f80ce9e0d3c64b60 Mon Sep 17 00:00:00 2001 From: 13r0ck Date: Fri, 27 Jan 2023 13:25:04 -0700 Subject: Fix: Clippy lint 'uninlined_format_args' --- native/src/window/action.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'native/src/window/action.rs') diff --git a/native/src/window/action.rs b/native/src/window/action.rs index 37fcc273..525434e4 100644 --- a/native/src/window/action.rs +++ b/native/src/window/action.rs @@ -106,15 +106,14 @@ impl fmt::Debug for Action { Self::Drag => write!(f, "Action::Drag"), Self::Resize { width, height } => write!( f, - "Action::Resize {{ widget: {}, height: {} }}", - width, height + "Action::Resize {{ widget: {width}, height: {height} }}" ), - Self::Maximize(value) => write!(f, "Action::Maximize({})", value), - Self::Minimize(value) => write!(f, "Action::Minimize({}", value), + Self::Maximize(value) => write!(f, "Action::Maximize({value})"), + Self::Minimize(value) => write!(f, "Action::Minimize({value}"), Self::Move { x, y } => { - write!(f, "Action::Move {{ x: {}, y: {} }}", x, y) + write!(f, "Action::Move {{ x: {x}, y: {y} }}") } - Self::SetMode(mode) => write!(f, "Action::SetMode({:?})", mode), + Self::SetMode(mode) => write!(f, "Action::SetMode({mode:?})"), Self::FetchMode(_) => write!(f, "Action::FetchMode"), Self::ToggleMaximize => write!(f, "Action::ToggleMaximize"), Self::ToggleDecorations => write!(f, "Action::ToggleDecorations"), -- cgit From ecc5bfaeff6503e9e0752035c5e0c94c5a5263a2 Mon Sep 17 00:00:00 2001 From: Héctor Ramón Jiménez Date: Tue, 31 Jan 2023 04:04:29 +0100 Subject: Improve consistency of `window::Action` --- native/src/window/action.rs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'native/src/window/action.rs') diff --git a/native/src/window/action.rs b/native/src/window/action.rs index 525434e4..d277649b 100644 --- a/native/src/window/action.rs +++ b/native/src/window/action.rs @@ -33,18 +33,19 @@ pub enum Action { /// The new logical y location of the window y: i32, }, - /// Set the [`Mode`] of the window. - SetMode(Mode), + /// Change the [`Mode`] of the window. + ChangeMode(Mode), /// Fetch the current [`Mode`] of the window. FetchMode(Box T + 'static>), - /// Sets the window to maximized or back + /// Toggle the window to maximized or back ToggleMaximize, - /// Toggles whether window has decorations + /// Toggle whether window has decorations. + /// /// ## Platform-specific /// - **X11:** Not implemented. /// - **Web:** Unsupported. ToggleDecorations, - /// Requests user attention to the window, this has no effect if the application + /// Request user attention to the window, this has no effect if the application /// is already focused. How requesting for user attention manifests is platform dependent, /// see [`UserAttentionType`] for details. /// @@ -58,7 +59,7 @@ pub enum Action { /// - **X11:** Requests for user attention must be manually cleared. /// - **Wayland:** Requires `xdg_activation_v1` protocol, `None` has no effect. RequestUserAttention(Option), - /// Brings the window to the front and sets input focus. Has no effect if the window is + /// Bring the window to the front and sets input focus. Has no effect if the window is /// already in focus, minimized, or not visible. /// /// This method steals input focus from other applications. Do not use this method unless @@ -87,7 +88,7 @@ impl Action { Self::Maximize(bool) => Action::Maximize(bool), Self::Minimize(bool) => Action::Minimize(bool), Self::Move { x, y } => Action::Move { x, y }, - Self::SetMode(mode) => Action::SetMode(mode), + Self::ChangeMode(mode) => Action::ChangeMode(mode), Self::FetchMode(o) => Action::FetchMode(Box::new(move |s| f(o(s)))), Self::ToggleMaximize => Action::ToggleMaximize, Self::ToggleDecorations => Action::ToggleDecorations, @@ -113,7 +114,7 @@ impl fmt::Debug for Action { Self::Move { x, y } => { write!(f, "Action::Move {{ x: {x}, y: {y} }}") } - Self::SetMode(mode) => write!(f, "Action::SetMode({mode:?})"), + Self::ChangeMode(mode) => write!(f, "Action::SetMode({mode:?})"), Self::FetchMode(_) => write!(f, "Action::FetchMode"), Self::ToggleMaximize => write!(f, "Action::ToggleMaximize"), Self::ToggleDecorations => write!(f, "Action::ToggleDecorations"), -- cgit From 98a717383acf71d7939d7cc90d350743487f0380 Mon Sep 17 00:00:00 2001 From: Héctor Ramón Jiménez Date: Tue, 31 Jan 2023 04:08:19 +0100 Subject: Write missing `window::Action` helpers in `window` --- native/src/window/action.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'native/src/window/action.rs') diff --git a/native/src/window/action.rs b/native/src/window/action.rs index d277649b..168974bc 100644 --- a/native/src/window/action.rs +++ b/native/src/window/action.rs @@ -47,7 +47,7 @@ pub enum Action { ToggleDecorations, /// Request user attention to the window, this has no effect if the application /// is already focused. How requesting for user attention manifests is platform dependent, - /// see [`UserAttentionType`] for details. + /// see [`UserAttention`] for details. /// /// Providing `None` will unset the request for user attention. Unsetting the request for /// user attention might not be done automatically by the WM when the window receives input. -- cgit