From 2065a40f642589134142a740ff4198deaa4c378b Mon Sep 17 00:00:00 2001
From: Héctor Ramón Jiménez <hector0193@gmail.com>
Date: Sat, 9 Jul 2022 18:42:41 +0200
Subject: Fix `clippy` lints for all crates and features

... and check those in CI as well!
---
 graphics/src/font/source.rs                | 6 ++++++
 graphics/src/widget/canvas/path/builder.rs | 6 ++++++
 graphics/src/widget/pure/qr_code.rs        | 8 ++++----
 graphics/src/widget/qr_code.rs             | 8 ++++----
 graphics/src/window/gl_compositor.rs       | 3 +++
 5 files changed, 23 insertions(+), 8 deletions(-)

(limited to 'graphics/src')

diff --git a/graphics/src/font/source.rs b/graphics/src/font/source.rs
index a2d3f51d..c0b50e1d 100644
--- a/graphics/src/font/source.rs
+++ b/graphics/src/font/source.rs
@@ -37,3 +37,9 @@ impl Source {
         }
     }
 }
+
+impl Default for Source {
+    fn default() -> Self {
+        Self::new()
+    }
+}
diff --git a/graphics/src/widget/canvas/path/builder.rs b/graphics/src/widget/canvas/path/builder.rs
index 2f1f85a0..05316d8a 100644
--- a/graphics/src/widget/canvas/path/builder.rs
+++ b/graphics/src/widget/canvas/path/builder.rs
@@ -151,3 +151,9 @@ impl Builder {
         }
     }
 }
+
+impl Default for Builder {
+    fn default() -> Self {
+        Self::new()
+    }
+}
diff --git a/graphics/src/widget/pure/qr_code.rs b/graphics/src/widget/pure/qr_code.rs
index 23a8ceb6..bff391fe 100644
--- a/graphics/src/widget/pure/qr_code.rs
+++ b/graphics/src/widget/pure/qr_code.rs
@@ -53,12 +53,12 @@ where
     }
 }
 
-impl<'a, Message, B, T> Into<Element<'a, Message, Renderer<B, T>>>
-    for QRCode<'a>
+impl<'a, Message, B, T> From<QRCode<'a>>
+    for Element<'a, Message, Renderer<B, T>>
 where
     B: Backend,
 {
-    fn into(self) -> Element<'a, Message, Renderer<B, T>> {
-        Element::new(self)
+    fn from(qr_code: QRCode<'a>) -> Self {
+        Self::new(qr_code)
     }
 }
diff --git a/graphics/src/widget/qr_code.rs b/graphics/src/widget/qr_code.rs
index 86a27fd0..1a5c0b0a 100644
--- a/graphics/src/widget/qr_code.rs
+++ b/graphics/src/widget/qr_code.rs
@@ -125,13 +125,13 @@ where
     }
 }
 
-impl<'a, Message, B, T> Into<Element<'a, Message, Renderer<B, T>>>
-    for QRCode<'a>
+impl<'a, Message, B, T> From<QRCode<'a>>
+    for Element<'a, Message, Renderer<B, T>>
 where
     B: Backend,
 {
-    fn into(self) -> Element<'a, Message, Renderer<B, T>> {
-        Element::new(self)
+    fn from(qr_code: QRCode<'a>) -> Self {
+        Self::new(qr_code)
     }
 }
 
diff --git a/graphics/src/window/gl_compositor.rs b/graphics/src/window/gl_compositor.rs
index 4ff17366..722e4d9c 100644
--- a/graphics/src/window/gl_compositor.rs
+++ b/graphics/src/window/gl_compositor.rs
@@ -35,6 +35,9 @@ pub trait GLCompositor: Sized {
     /// Creates a new [`GLCompositor`] and [`Renderer`] with the given
     /// [`Settings`] and an OpenGL address loader function.
     ///
+    /// # Safety
+    /// The `loader_function` should resolve to valid OpenGL bindings.
+    ///
     /// [`Renderer`]: crate::Renderer
     /// [`Backend`]: crate::Backend
     /// [`Settings`]: Self::Settings
-- 
cgit