From 55eaeceec8520e008260c8b5630b53d6d5ecdfb6 Mon Sep 17 00:00:00 2001 From: Tanner Rogalsky Date: Sun, 14 Nov 2021 11:03:15 -0500 Subject: Collect the platform-specific concrete future implementations into mods. --- futures/src/lib.rs | 69 +++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 47 insertions(+), 22 deletions(-) diff --git a/futures/src/lib.rs b/futures/src/lib.rs index 01cf5c89..ba7c558b 100644 --- a/futures/src/lib.rs +++ b/futures/src/lib.rs @@ -37,33 +37,58 @@ pub mod time; pub use command::Command; pub use executor::Executor; +pub use platform::*; pub use runtime::Runtime; pub use subscription::Subscription; -/// A boxed static future. -/// -/// - On native platforms, it needs a `Send` requirement. -/// - On the Web platform, it does not need a `Send` requirement. #[cfg(not(target_arch = "wasm32"))] -pub type BoxFuture = futures::future::BoxFuture<'static, T>; +mod platform { + /// A boxed static future. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub type BoxFuture = futures::future::BoxFuture<'static, T>; -/// A boxed static future. -/// -/// - On native platforms, it needs a `Send` requirement. -/// - On the Web platform, it does not need a `Send` requirement. -#[cfg(target_arch = "wasm32")] -pub type BoxFuture = futures::future::LocalBoxFuture<'static, T>; + /// A boxed static stream. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub type BoxStream = futures::stream::BoxStream<'static, T>; -/// A boxed static stream. -/// -/// - On native platforms, it needs a `Send` requirement. -/// - On the Web platform, it does not need a `Send` requirement. -#[cfg(not(target_arch = "wasm32"))] -pub type BoxStream = futures::stream::BoxStream<'static, T>; + /// Boxes a stream. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub fn boxed_stream(stream: S) -> BoxStream + where + S: futures::Stream + Send + 'static, + { + futures::stream::StreamExt::boxed(stream) + } +} -/// A boxed static stream. -/// -/// - On native platforms, it needs a `Send` requirement. -/// - On the Web platform, it does not need a `Send` requirement. #[cfg(target_arch = "wasm32")] -pub type BoxStream = futures::stream::LocalBoxStream<'static, T>; +mod platform { + /// A boxed static future. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub type BoxFuture = futures::future::LocalBoxFuture<'static, T>; + + /// A boxed static stream. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub type BoxStream = futures::stream::LocalBoxStream<'static, T>; + + /// Boxes a stream. + /// + /// - On native platforms, it needs a `Send` requirement. + /// - On the Web platform, it does not need a `Send` requirement. + pub fn boxed_stream(stream: S) -> BoxStream + where + S: futures::Stream + 'static, + { + futures::stream::StreamExt::boxed_local(stream) + } +} -- cgit From 24d7d4740fd163b3d3f52fb8ea41233001ab6b93 Mon Sep 17 00:00:00 2001 From: Tanner Rogalsky Date: Sun, 14 Nov 2021 11:04:20 -0500 Subject: Use iced_futures utilities to make native work under wasm32 target. --- native/src/subscription.rs | 4 ++-- native/src/subscription/events.rs | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/native/src/subscription.rs b/native/src/subscription.rs index ff954382..2950879c 100644 --- a/native/src/subscription.rs +++ b/native/src/subscription.rs @@ -1,7 +1,7 @@ //! Listen to external events in your application. use crate::event::{self, Event}; use crate::Hasher; -use iced_futures::futures::stream::BoxStream; +use iced_futures::BoxStream; /// A request to listen to external events. /// @@ -21,7 +21,7 @@ pub type Subscription = /// A stream of runtime events. /// /// It is the input of a [`Subscription`] in the native runtime. -pub type EventStream = BoxStream<'static, (Event, event::Status)>; +pub type EventStream = BoxStream<(Event, event::Status)>; /// A native [`Subscription`] tracker. pub type Tracker = diff --git a/native/src/subscription/events.rs b/native/src/subscription/events.rs index f689f3af..ca143bb3 100644 --- a/native/src/subscription/events.rs +++ b/native/src/subscription/events.rs @@ -27,10 +27,9 @@ where self: Box, event_stream: EventStream, ) -> BoxStream { - event_stream - .filter_map(move |(event, status)| { - future::ready((self.f)(event, status)) - }) - .boxed() + let stream = event_stream.filter_map(move |(event, status)| { + future::ready((self.f)(event, status)) + }); + iced_futures::boxed_stream(stream) } } -- cgit