Fix invisible window on Windows

... by reverting the changes that were supposed to hide the window
initially and only show it after rendering the first frame.

2 files changed, 7 insertions, 19 deletions

diff --git a/winit/src/application.rs b/winit/src/application.rs
index ecec6043..a576126e 100644
--- a/winit/src/application.rs
+++ b/winit/src/application.rs
@@ -137,15 +137,11 @@ where
         runtime.enter(|| A::new(flags))
     };
 
-    let should_be_visible = settings.window.visible;
-    let builder = settings
-        .window
-        .into_builder(
-            &application.title(),
-            event_loop.primary_monitor(),
-            settings.id,
-        )
-        .with_visible(false);
+    let builder = settings.window.into_builder(
+        &application.title(),
+        event_loop.primary_monitor(),
+        settings.id,
+    );
 
     log::info!("Window builder: {:#?}", builder);
 
@@ -182,7 +178,6 @@ where
         receiver,
         init_command,
         window,
-        should_be_visible,
         settings.exit_on_close_request,
     ));
 
@@ -233,7 +228,6 @@ async fn run_instance<A, E, C>(
     mut receiver: mpsc::UnboundedReceiver<winit::event::Event<'_, A::Message>>,
     init_command: Command<A::Message>,
     window: winit::window::Window,
-    should_be_visible: bool,
     exit_on_close_request: bool,
 ) where
     A: Application + 'static,
@@ -247,7 +241,6 @@ async fn run_instance<A, E, C>(
     let mut clipboard = Clipboard::connect(&window);
     let mut cache = user_interface::Cache::default();
     let mut surface = compositor.create_surface(&window);
-    let mut visible = false;
 
     let mut state = State::new(&application, &window);
     let mut viewport_version = state.viewport_version();
@@ -447,12 +440,6 @@ async fn run_instance<A, E, C>(
                     Ok(()) => {
                         debug.render_finished();
 
-                        if !visible && should_be_visible {
-                            window.set_visible(true);
-
-                            visible = true;
-                        }
-
                         // TODO: Handle animations!
                         // Maybe we can use `ControlFlow::WaitUntil` for this.
                     }
diff --git a/winit/src/settings.rs b/winit/src/settings.rs
index 7175b9ed..a04ec863 100644
--- a/winit/src/settings.rs
+++ b/winit/src/settings.rs
@@ -106,7 +106,8 @@ impl Window {
             .with_decorations(self.decorations)
             .with_transparent(self.transparent)
             .with_window_icon(self.icon)
-            .with_always_on_top(self.always_on_top);
+            .with_always_on_top(self.always_on_top)
+            .with_visible(self.visible);
 
         if let Some(position) = conversion::position(
             primary_monitor.as_ref(),