Merge pull request #56 from hecrj/example/filter-todos

Draw checkmark icon and filter todos

2 files changed, 26 insertions, 9 deletions

diff --git a/wgpu/src/renderer.rs b/wgpu/src/renderer.rs
index d3bdc878..52764248 100644
--- a/wgpu/src/renderer.rs
+++ b/wgpu/src/renderer.rs
@@ -344,11 +344,27 @@ impl Renderer {
             for text in layer.text.iter() {
                 // Target physical coordinates directly to avoid blurry text
                 let text = wgpu_glyph::Section {
+                    // TODO: We `round` here to avoid rerasterizing text when
+                    // its position changes slightly. This can make text feel a
+                    // bit "jumpy". We may be able to do better once we improve
+                    // our text rendering/caching pipeline.
                     screen_position: (
                         (text.screen_position.0 * dpi).round(),
                         (text.screen_position.1 * dpi).round(),
                     ),
-                    bounds: (text.bounds.0 * dpi, text.bounds.1 * dpi),
+                    // TODO: Fix precision issues with some DPI factors.
+                    //
+                    // The `ceil` here can cause some words to render on the
+                    // same line when they should not.
+                    //
+                    // Ideally, `wgpu_glyph` should be able to compute layout
+                    // using logical positions, and then apply the proper
+                    // DPI scaling. This would ensure that both measuring and
+                    // rendering follow the same layout rules.
+                    bounds: (
+                        (text.bounds.0 * dpi).ceil(),
+                        (text.bounds.1 * dpi).ceil(),
+                    ),
                     scale: wgpu_glyph::Scale {
                         x: text.scale.x * dpi,
                         y: text.scale.y * dpi,
diff --git a/wgpu/src/renderer/widget/checkbox.rs b/wgpu/src/renderer/widget/checkbox.rs
index c2d7911c..aedb821c 100644
--- a/wgpu/src/renderer/widget/checkbox.rs
+++ b/wgpu/src/renderer/widget/checkbox.rs
@@ -74,14 +74,15 @@ impl checkbox::Renderer for Renderer {
         (
             Primitive::Group {
                 primitives: if checkbox.is_checked {
-                    // TODO: Draw an actual icon
-                    let (check, _) = text::Renderer::draw(
-                        self,
-                        &Text::new("X")
-                            .horizontal_alignment(HorizontalAlignment::Center)
-                            .vertical_alignment(VerticalAlignment::Center),
-                        checkbox_layout,
-                    );
+                    let check = Primitive::Text {
+                        content: crate::text::CHECKMARK_ICON.to_string(),
+                        font: crate::text::BUILTIN_ICONS,
+                        size: checkbox_bounds.height * 0.7,
+                        bounds: checkbox_bounds,
+                        color: [0.3, 0.3, 0.3].into(),
+                        horizontal_alignment: HorizontalAlignment::Center,
+                        vertical_alignment: VerticalAlignment::Center,
+                    };
 
                     vec![checkbox_border, checkbox_box, check, label]
                 } else {