diff options
author | 2019-11-14 03:00:33 +0100 | |
---|---|---|
committer | 2019-11-14 03:00:57 +0100 | |
commit | 00479d8bcdf619dab8a3eaa47ff551c6c3a0ac1a (patch) | |
tree | 467f700ebc630d1f27baf620eb6f6e8306351d7e /wgpu/src/renderer.rs | |
parent | be5466a0a7ee6a16b5c07e61c9a22068ad8e127f (diff) | |
download | iced-00479d8bcdf619dab8a3eaa47ff551c6c3a0ac1a.tar.gz iced-00479d8bcdf619dab8a3eaa47ff551c6c3a0ac1a.tar.bz2 iced-00479d8bcdf619dab8a3eaa47ff551c6c3a0ac1a.zip |
Fix text bounds in `iced_wgpu` on nonintegral DPI
Diffstat (limited to '')
-rw-r--r-- | wgpu/src/renderer.rs | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/wgpu/src/renderer.rs b/wgpu/src/renderer.rs index d3bdc878..52764248 100644 --- a/wgpu/src/renderer.rs +++ b/wgpu/src/renderer.rs @@ -344,11 +344,27 @@ impl Renderer { for text in layer.text.iter() { // Target physical coordinates directly to avoid blurry text let text = wgpu_glyph::Section { + // TODO: We `round` here to avoid rerasterizing text when + // its position changes slightly. This can make text feel a + // bit "jumpy". We may be able to do better once we improve + // our text rendering/caching pipeline. screen_position: ( (text.screen_position.0 * dpi).round(), (text.screen_position.1 * dpi).round(), ), - bounds: (text.bounds.0 * dpi, text.bounds.1 * dpi), + // TODO: Fix precision issues with some DPI factors. + // + // The `ceil` here can cause some words to render on the + // same line when they should not. + // + // Ideally, `wgpu_glyph` should be able to compute layout + // using logical positions, and then apply the proper + // DPI scaling. This would ensure that both measuring and + // rendering follow the same layout rules. + bounds: ( + (text.bounds.0 * dpi).ceil(), + (text.bounds.1 * dpi).ceil(), + ), scale: wgpu_glyph::Scale { x: text.scale.x * dpi, y: text.scale.y * dpi, |