diff options
author | 2019-12-05 01:57:35 +0100 | |
---|---|---|
committer | 2019-12-05 01:57:35 +0100 | |
commit | e92ea48e8814b42fc566017db085ca9bdaf3c272 (patch) | |
tree | 48413064237f8b00b4b4c8668a96fc5ca79d995a | |
parent | f87ddf1056327551b4a2bba9e98cbb7816b6666c (diff) | |
download | iced-e92ea48e8814b42fc566017db085ca9bdaf3c272.tar.gz iced-e92ea48e8814b42fc566017db085ca9bdaf3c272.tar.bz2 iced-e92ea48e8814b42fc566017db085ca9bdaf3c272.zip |
Make `Button::background` generic
-rw-r--r-- | examples/pokedex.rs | 6 | ||||
-rw-r--r-- | examples/todos.rs | 10 | ||||
-rw-r--r-- | examples/tour.rs | 13 | ||||
-rw-r--r-- | native/CHANGELOG.md | 1 | ||||
-rw-r--r-- | native/src/widget/button.rs | 4 | ||||
-rw-r--r-- | web/CHANGELOG.md | 3 | ||||
-rw-r--r-- | web/src/widget/button.rs | 4 |
7 files changed, 21 insertions, 20 deletions
diff --git a/examples/pokedex.rs b/examples/pokedex.rs index 6893bb73..b9daeabd 100644 --- a/examples/pokedex.rs +++ b/examples/pokedex.rs @@ -1,6 +1,6 @@ use iced::{ - button, image, Align, Application, Button, Color, Column, - Command, Container, Element, Image, Length, Row, Settings, Text, + button, image, Align, Application, Button, Color, Column, Command, + Container, Element, Image, Length, Row, Settings, Text, }; pub fn main() { @@ -225,7 +225,7 @@ impl From<reqwest::Error> for Error { fn button<'a>(state: &'a mut button::State, text: &str) -> Button<'a, Message> { Button::new(state, Text::new(text).color(Color::WHITE)) - .background(Color::from_rgb(0.11, 0.42, 0.87).into()) + .background(Color::from_rgb(0.11, 0.42, 0.87)) .border_radius(10) .padding(10) } diff --git a/examples/todos.rs b/examples/todos.rs index 684c9fea..5f435fdc 100644 --- a/examples/todos.rs +++ b/examples/todos.rs @@ -1,7 +1,7 @@ use iced::{ - button, scrollable, text_input, Align, Application, Button, - Checkbox, Color, Column, Command, Container, Element, Font, - HorizontalAlignment, Length, Row, Scrollable, Settings, Text, TextInput, + button, scrollable, text_input, Align, Application, Button, Checkbox, + Color, Column, Command, Container, Element, Font, HorizontalAlignment, + Length, Row, Scrollable, Settings, Text, TextInput, }; use serde::{Deserialize, Serialize}; @@ -332,7 +332,7 @@ impl Task { .on_press(TaskMessage::Delete) .padding(10) .border_radius(5) - .background(Color::from_rgb(0.8, 0.2, 0.2).into()), + .background(Color::from_rgb(0.8, 0.2, 0.2)), ) .into() } @@ -361,7 +361,7 @@ impl Controls { let label = Text::new(label).size(16).width(Length::Shrink); let button = if filter == current_filter { Button::new(state, label.color(Color::WHITE)) - .background(Color::from_rgb(0.2, 0.2, 0.7).into()) + .background(Color::from_rgb(0.2, 0.2, 0.7)) } else { Button::new(state, label) }; diff --git a/examples/tour.rs b/examples/tour.rs index 53a8e662..b06fbc37 100644 --- a/examples/tour.rs +++ b/examples/tour.rs @@ -1,7 +1,7 @@ use iced::{ - button, scrollable, slider, text_input, Button, Checkbox, - Color, Column, Container, Element, HorizontalAlignment, Image, Length, - Radio, Row, Sandbox, Scrollable, Settings, Slider, Text, TextInput, + button, scrollable, slider, text_input, Button, Checkbox, Color, Column, + Container, Element, HorizontalAlignment, Image, Length, Radio, Row, + Sandbox, Scrollable, Settings, Slider, Text, TextInput, }; pub fn main() { @@ -684,17 +684,14 @@ fn primary_button<'a, Message>( state: &'a mut button::State, label: &str, ) -> Button<'a, Message> { - button(state, label) - .background(Color::from_rgb(0.11, 0.42, 0.87).into()) + button(state, label).background(Color::from_rgb(0.11, 0.42, 0.87)) } fn secondary_button<'a, Message>( state: &'a mut button::State, label: &str, ) -> Button<'a, Message> { - button(state, label) - .background(Color::from_rgb(0.4, 0.4, 0.4).into()) - + button(state, label).background(Color::from_rgb(0.4, 0.4, 0.4)) } #[derive(Debug, Clone, Copy, PartialEq, Eq)] diff --git a/native/CHANGELOG.md b/native/CHANGELOG.md index 2a4bba3f..cf5b79dd 100644 --- a/native/CHANGELOG.md +++ b/native/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - `Image::new` takes an `Into<image::Handle>` now instead of an `Into<String>`. [#90] +- `Button::background` takes an `Into<Background>` now instead of a `Background`. ### Fixed - `Image` widget not keeping aspect ratio consistently. [#90] diff --git a/native/src/widget/button.rs b/native/src/widget/button.rs index 023c4ee8..3348c58c 100644 --- a/native/src/widget/button.rs +++ b/native/src/widget/button.rs @@ -89,8 +89,8 @@ impl<'a, Message, Renderer> Button<'a, Message, Renderer> { /// /// [`Button`]: struct.Button.html /// [`Background`]: ../../struct.Background.html - pub fn background(mut self, background: Background) -> Self { - self.background = Some(background); + pub fn background<T: Into<Background>>(mut self, background: T) -> Self { + self.background = Some(background.into()); self } diff --git a/web/CHANGELOG.md b/web/CHANGELOG.md index 0bdb9c37..ed02519a 100644 --- a/web/CHANGELOG.md +++ b/web/CHANGELOG.md @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Changed +- `Button::background` takes an `Into<Background>` now instead of a `Background`. + ### Fixed - Render not being scheduled after `Command` futures finishing. diff --git a/web/src/widget/button.rs b/web/src/widget/button.rs index 889c0ab1..4cc8b3de 100644 --- a/web/src/widget/button.rs +++ b/web/src/widget/button.rs @@ -81,8 +81,8 @@ impl<'a, Message> Button<'a, Message> { /// /// [`Button`]: struct.Button.html /// [`Background`]: ../../struct.Background.html - pub fn background(mut self, background: Background) -> Self { - self.background = Some(background); + pub fn background<T: Into<Background>>(mut self, background: T) -> Self { + self.background = Some(background.into()); self } |