diff options
author | 2020-02-18 02:28:15 +0100 | |
---|---|---|
committer | 2020-02-18 02:28:15 +0100 | |
commit | 692216042307c0ff0d792d1bba6928e499a65d1f (patch) | |
tree | a22caa4e4bbbf318bb3fc6ed2c5498f34db40536 | |
parent | 668f627532dacd5441f6990a39c327db1da40083 (diff) | |
download | iced-692216042307c0ff0d792d1bba6928e499a65d1f.tar.gz iced-692216042307c0ff0d792d1bba6928e499a65d1f.tar.bz2 iced-692216042307c0ff0d792d1bba6928e499a65d1f.zip |
Pull `Checkbox` default constants from its `Renderer`
-rw-r--r-- | native/src/renderer/null.rs | 9 | ||||
-rw-r--r-- | native/src/widget/checkbox.rs | 26 | ||||
-rw-r--r-- | native/src/widget/radio.rs | 2 | ||||
-rw-r--r-- | native/src/widget/text.rs | 8 | ||||
-rw-r--r-- | wgpu/src/renderer/widget/checkbox.rs | 7 | ||||
-rw-r--r-- | wgpu/src/renderer/widget/text.rs | 7 |
6 files changed, 28 insertions, 31 deletions
diff --git a/native/src/renderer/null.rs b/native/src/renderer/null.rs index 2e0b6f32..0fcce5ad 100644 --- a/native/src/renderer/null.rs +++ b/native/src/renderer/null.rs @@ -47,9 +47,7 @@ impl row::Renderer for Null { } impl text::Renderer for Null { - fn default_size(&self) -> u16 { - 20 - } + const DEFAULT_SIZE: u16 = 20; fn measure( &self, @@ -179,9 +177,8 @@ impl radio::Renderer for Null { impl checkbox::Renderer for Null { type Style = (); - fn default_size(&self) -> u32 { - 20 - } + const DEFAULT_SIZE: u16 = 20; + const DEFAULT_SPACING: u16 = 15; fn draw( &mut self, diff --git a/native/src/widget/checkbox.rs b/native/src/widget/checkbox.rs index 669437bc..b36d10a4 100644 --- a/native/src/widget/checkbox.rs +++ b/native/src/widget/checkbox.rs @@ -26,18 +26,20 @@ use crate::{ /// ///  #[allow(missing_debug_implementations)] -pub struct Checkbox<Message, Renderer: self::Renderer> { +pub struct Checkbox<Message, Renderer: self::Renderer + text::Renderer> { is_checked: bool, on_toggle: Box<dyn Fn(bool) -> Message>, label: String, - size: u16, width: Length, + size: u16, spacing: u16, text_size: u16, style: Renderer::Style, } -impl<Message, Renderer: self::Renderer> Checkbox<Message, Renderer> { +impl<Message, Renderer: self::Renderer + text::Renderer> + Checkbox<Message, Renderer> +{ /// Creates a new [`Checkbox`]. /// /// It expects: @@ -56,10 +58,10 @@ impl<Message, Renderer: self::Renderer> Checkbox<Message, Renderer> { is_checked, on_toggle: Box::new(f), label: String::from(label), - size: 20, width: Length::Shrink, - spacing: 15, - text_size: 20, + size: <Renderer as self::Renderer>::DEFAULT_SIZE, + spacing: Renderer::DEFAULT_SPACING, + text_size: <Renderer as text::Renderer>::DEFAULT_SIZE, style: Renderer::Style::default(), } } @@ -135,7 +137,8 @@ where .push( Text::new(&self.label) .width(self.width) - .size(self.text_size)) + .size(self.text_size), + ) .layout(renderer, limits) } @@ -217,10 +220,15 @@ pub trait Renderer: crate::Renderer { /// The style supported by this renderer. type Style: Default; - /// Returns the default size of a [`Checkbox`]. + /// The default size of a [`Checkbox`]. + /// + /// [`Checkbox`]: struct.Checkbox.html + const DEFAULT_SIZE: u16; + + /// The default spacing of a [`Checkbox`]. /// /// [`Checkbox`]: struct.Checkbox.html - fn default_size(&self) -> u32; + const DEFAULT_SPACING: u16; /// Draws a [`Checkbox`]. /// diff --git a/native/src/widget/radio.rs b/native/src/widget/radio.rs index 99743ec3..cdc4862c 100644 --- a/native/src/widget/radio.rs +++ b/native/src/widget/radio.rs @@ -149,7 +149,7 @@ where defaults, label_layout.bounds(), &self.label, - text::Renderer::default_size(renderer), + <Renderer as text::Renderer>::DEFAULT_SIZE, Font::Default, None, HorizontalAlignment::Left, diff --git a/native/src/widget/text.rs b/native/src/widget/text.rs index e4490fb6..7d8cad6e 100644 --- a/native/src/widget/text.rs +++ b/native/src/widget/text.rs @@ -131,7 +131,7 @@ where ) -> layout::Node { let limits = limits.width(self.width).height(self.height); - let size = self.size.unwrap_or(renderer.default_size()); + let size = self.size.unwrap_or(Renderer::DEFAULT_SIZE); let bounds = limits.max(); @@ -154,7 +154,7 @@ where defaults, layout.bounds(), &self.content, - self.size.unwrap_or(renderer.default_size()), + self.size.unwrap_or(Renderer::DEFAULT_SIZE), self.font, self.color, self.horizontal_alignment, @@ -179,10 +179,10 @@ where /// [renderer]: ../../renderer/index.html /// [`UserInterface`]: ../../struct.UserInterface.html pub trait Renderer: crate::Renderer { - /// Returns the default size of the [`Text`]. + /// The default size of [`Text`]. /// /// [`Text`]: struct.Text.html - fn default_size(&self) -> u16; + const DEFAULT_SIZE: u16; /// Measures the [`Text`] in the given bounds and returns the minimum /// boundaries that can fit the contents. diff --git a/wgpu/src/renderer/widget/checkbox.rs b/wgpu/src/renderer/widget/checkbox.rs index 17121eea..1a0585d3 100644 --- a/wgpu/src/renderer/widget/checkbox.rs +++ b/wgpu/src/renderer/widget/checkbox.rs @@ -3,14 +3,11 @@ use iced_native::{ checkbox, HorizontalAlignment, MouseCursor, Rectangle, VerticalAlignment, }; -const SIZE: f32 = 28.0; - impl checkbox::Renderer for Renderer { type Style = Box<dyn StyleSheet>; - fn default_size(&self) -> u32 { - SIZE as u32 - } + const DEFAULT_SIZE: u16 = 20; + const DEFAULT_SPACING: u16 = 15; fn draw( &mut self, diff --git a/wgpu/src/renderer/widget/text.rs b/wgpu/src/renderer/widget/text.rs index d61c5523..33e549cd 100644 --- a/wgpu/src/renderer/widget/text.rs +++ b/wgpu/src/renderer/widget/text.rs @@ -6,13 +6,8 @@ use iced_native::{ use std::f32; -// TODO: Obtain from renderer configuration -const DEFAULT_TEXT_SIZE: f32 = 20.0; - impl text::Renderer for Renderer { - fn default_size(&self) -> u16 { - DEFAULT_TEXT_SIZE as u16 - } + const DEFAULT_SIZE: u16 = 20; fn measure( &self, |