From 9a21f5eaa3920c51371ee5bd0634e148d825dd71 Mon Sep 17 00:00:00 2001 From: Dirkjan Ochtman Date: Mon, 4 Sep 2017 20:31:28 +0200 Subject: Tighten up code for join filter handling --- askama_shared/src/generator.rs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/askama_shared/src/generator.rs b/askama_shared/src/generator.rs index 836da34..4d101a1 100644 --- a/askama_shared/src/generator.rs +++ b/askama_shared/src/generator.rs @@ -238,25 +238,18 @@ impl<'a> Generator<'a> { self.write(")"); } + // Force type coercion on first argument to `join` filter (see #39). fn _visit_join_filter(&mut self, args: &[Expr]) { - // this is a separate handler because we need to generate code like - // this to force auto-deref for first argument: - // `join((&&&&&&self.s).into_iter(), ", ")` - // otherwise, we were getting errors described in PR #39 self.write("::askama::filters::join((&"); - for (i, arg) in args.iter().enumerate() { if i > 0 { self.write(", &"); } - self.visit_expr(arg); - if i == 0 { self.write(").into_iter()"); } } - self.write(")?"); } -- cgit